Implement openconfig-system for IOS#40
Merged
FragmentedPacket merged 22 commits intodevelopfrom Feb 28, 2020
Merged
Conversation
FragmentedPacket
suggested changes
Feb 19, 2020
Contributor
FragmentedPacket
left a comment
FragmentedPacket
left a comment
There was a problem hiding this comment.
A few comments and issues I see, but thanks for all the hard work on this. Creating the new parsers and translators are a lot of work!
FragmentedPacket
suggested changes
Feb 28, 2020
Contributor
|
We're almost there! Thanks again for this work |
FragmentedPacket
approved these changes
Feb 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a copy of #33 because it must have referenced an old fork, and I borked fixing it. :(
This one probably needs a bit of discussion, so please review closely. "replace" operations don't always make sense on IOS, particularly for things like system-level config. There is no way to my knowledge to "default" ntp config, tacacs, users, etc. I have raised an exception when replace is called, and there is a test to reflect it.
Merged with develop, ready for review.